Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow files to be directly deleted in onedrive #138908

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Feb 20, 2025

Breaking change

Proposed change

Allows the user to configure the OneDrive integration to bypass the recycle bin when the backup integration cleans up existing backups to save disk space.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj
Copy link
Member Author

zweckj commented Feb 20, 2025

Thanks Shay!

@zweckj zweckj merged commit 9f7c464 into home-assistant:dev Feb 20, 2025
32 checks passed
@zweckj zweckj deleted the onedrive/delete-permanently branch February 20, 2025 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@zweckj zweckj added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: onedrive new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: bronze quality-scale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants