Update pyvesync version

[cdnninja]

Proposed change

Bumping version of pyvesync library.

https://github.com/webdjoe/pyvesync/releases/tag/2.1.14
webdjoe/pyvesync@2.1.12...2.1.14

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[gjohansson-ST]

Please run python3 -m script.gen_requirements_all to update the requirements in all places. It seems to missing for tests.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[cdnninja]

I have corrected the missing file.

[gjohansson-ST]

Tests are failing so something has changed which probably needs fixing given it seems all devices are now being removed from snapshots.

[ncd7]

Has this PR now stalled? Any suggestions how we can debug the tests, if I find the time around the holidays I might sync and try that. This is a really popular device model so a lot of people are trying to get support in HA

[cdnninja]

Any support on why tests fail would be great! I haven't had time to dig in an am struggling to understand that part.

[ncd7]

gjohansson-ST

@gjohansson-ST , do you think you could offer @cdnninja some guidance?

[gjohansson-ST]

Something changed in the library so it's no longer adding all the devices as before.
So some code needs to be changed (I have no idea since I don't use this myself) and you have likely not tested the code either (the checklist is completely empty).

[webdjoe]

The issue is webdjoe/pyvesync@2.1.12...2.1.13#diff-ad4ecc16e9072e06d14ee98652e539c2712cb6a793a9f49b369ba4bfbb38a159R64 , configModule should be a mandatory property because it is required for some device functionality. I believe the HA tests do not include it in the testing data. This is stylistic and only going to impact testing, so I can roll it back in a new release. Unless you would like to add configModule to the devices in tests/components/vesync/fixtures/vesync-devices.json

[gjohansson-ST]

Tests should be as similar as possible to reality so if it's missing in the tests I would really prefer to see it added 👍

[webdjoe]

I agree, API calls are documented here

@cdnninja I am going upload a new pyvesync release in a few moments, so you might as well bump to the new version in this PR.

[webdjoe]

Released 2.1.14

[webdjoe]

The tests are failing due to the configModule attribute, it should be added each device in the device list. You should be able to make a stub value for all, e.g. "configModule": "configModule" https://github.com/home-assistant/core/blob/dev/tests/components/vesync/fixtures/vesync-devices.json

[cdnninja]

Tests have been updated and now pass. Let me know if it is preferred to move the tests to a separate PR.

[gjohansson-ST]

Thanks @cdnninja 👍