Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brands URLs to use fallback search parameter #100701

Closed
wants to merge 1 commit into from

Conversation

steverep
Copy link
Member

Proposed change

Needs home-assistant/brands#4708. Changes from /_/... to ...?fallback=true.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck
Copy link
Member

frenck commented Oct 7, 2023

Closing PR as the parent PR referenced has been closed as well.

../Frenck

@frenck frenck closed this Oct 7, 2023
@steverep
Copy link
Member Author

steverep commented Oct 7, 2023

Closing PR as the parent PR referenced has been closed as well.

As noted in the parent, it was replaced by home-assistant/brands#4722, which is still awaiting a review. If that is merged, I would intent to follow up with a switch to a search parameter, so this PR would still be relevant.

@frenck frenck reopened this Oct 7, 2023
@frenck
Copy link
Member

frenck commented Oct 7, 2023

Sorry missed that one @steverep! Re-opened the PR.

../Frenck

@frenck
Copy link
Member

frenck commented Nov 29, 2023

@steverep Is this PR now ready for a follow-up? Or can we close it for now?

../Frenck

@frenck frenck closed this Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants