-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrote scrapers for new ui #3
base: master
Are you sure you want to change the base?
Conversation
Thank you for the PR. It works for quite some texts, but I found some issues with others. These small changes improved it a lot for me:
and
The generated EPUBs now do not have an additional line break between paragraphs wich makes reading in some EBook Readers a little bit more awkward. |
@domaniko can you open a PR to merge your changes into my branch so they can be added to this PR with proper attribution? I'm also happy to just make your changes on my end and push them. |
Done so mueslimak3r#1 |
@mueslimak3r Could you please consider mueslimak3r#2 |
Issue with authors who only published single stories
Opening this as a draft because it hasn't been thoroughly tested, and hasn't been formatted to respect the "debug" flag.
Also, because I scrape the series-part list from a specific series' page, the series parts/stories don't have stats such as rating. Only one-shot stories get those stats
This was easier than handling clicking the "View Full 128 Part Series" button on the author works page before parsing the list from there. The list on the author's page is what has the stats in each story's card.
In its current state this is adequate for me, and I'll leave this as-is.
If anyone wants to finish what I've started, I'll keep an eye out and update this PR as needed.
Closes #2