-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File upload #171
Comments
Has there been any accessibility testing on this pattern? I can see in one example it uses Also wondering how errors are announced when multiple files are uploading? |
For tasklist, various colour status tags were descoped, I thought, because they were perceived to add little or no value to teh user and colours could be interpreted in different ways - does the same thinking perhaps apply here too? |
Hey @danlaceyhmrc We retired HMRC's supplemental guidance on tags a year ago when GDS made a number of changes to their guidance related to our concerns. Tag backgrounds have survived in the GDS guidance but are less used and light. |
This pattern needs more thought on how to handle the case where JavaScript isn’t available. Right now, the only mention of this is:
The yellow tag idea must be talking about when JS is available as it isn’t possible to update the page between selecting a file and the upload completing without JS. But manually refreshing the page, as suggested, would cancel any uploads still in progress—so that’s not a great solution. The page will refresh or redirect once the POST request completes. Until then, the file input field stays visible, which means users could try to upload more files or click submit again while waiting. So some extra guidance text will probably be needed for the non-js users to tell them to press submit and wait. Things to keep in mind with no JS:
|
File upload
Overview
We are working on a new file upload pattern for the HMRC Design Resources. Our services require some upload features not included in the GDS file upload component. Our goal is to improve the consistency and usability of our solutions.
Some considerations
Existing components or patterns
GOV Design System
https://design-system.service.gov.uk/components/file-upload/
Ministry of Justice
https://design-patterns.service.justice.gov.uk/patterns/upload-files/
Examples of services using file upload
Relevant discussions
File upload on GitHub
alphagov/govuk-design-system-backlog#49
Upload files on GitHub
#68
GOV.UK blog post
https://designnotes.blog.gov.uk/2017/02/14/some-design-tips-for-uploading-things/
MOJ multi-file upload on GitHub
ministryofjustice/moj-design-system-backlog#1
NHS file upload on GitHub
nhsuk/nhsuk-service-manual-community-backlog#93
Existing research
The text was updated successfully, but these errors were encountered: