fix(wrkspcs): interactive rename, save + load dir #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. I'll look into workspace I/O soon and see if I can resolve that problem. As for the main workspace, renaming it is problematic because it is a special case. |
hlissner
added a commit
that referenced
this pull request
Sep 28, 2017
+ The "main" workspace is no longer treated especially, and can be renamed or deleted. Fixes issue mentioned in #200. + In the disastrous event that there are no workspaces left, a main one is generated and switched to. Under no circumstances should the use be left in the nil perspective! + Fix the :tabr[ename] ex command throwing argument errors. + Refactored most workspace functions. + New command: +workspace/close-workspace-or-frame, which is bound to C-S-w in my private module.
|
I've pushed a fix for the main workspace to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started getting into doom's workspace usage today, and these seemed to fix a few issues – not sure if they're unique to my machine or not.
This fixes renaming workspaces to work interactively by prompting for a new name from the minibuffer.
This also fixes the saving and loading of workspaces, however, an error still shows up after saving saying that it failed, despite writing to the persp file (and successful re-loads following).
I'm curious if the 'main' workspace can be renamed dynamically - i tried some code to do so but hit a few issues so thought I'd ask if it was a true necessity to protect it.