New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra byte reservation in writeBoolList #398

Merged

themisir merged 1 commit into isar:master from dipu-bd:master

Aug 3, 2020

Contributor

dipu-bd commented Aug 3, 2020

writeBoolList method inside binary_writer_impl.dart is reserving 8 * length bytes, where it should suffice to reserve only length bytes.

This change does not impact readBoolList of BinaryReaderImpl.


          Remove extra byte reservation in writeBoolList

1dd37b5

Member

simc commented Aug 3, 2020

Thanks a lot. This was a stupid copy paste error...

themisir approved these changes

View reviewed changes

themisir merged commit 9ea7461 into isar:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet