Remove obsolete references to structured adresses

Author: amaierhofer

app/domain/export/tabular/people/participation_nds_row.rb

@@ -77,19 +77,11 @@ def second_language
     end
 
     def street
-      if FeatureGate.enabled?("structured_addresses")
-        entry.street
-      else
-        split_address[1]
-      end
+      entry.street
     end
 
     def housenumber
-      if FeatureGate.enabled?("structured_addresses")
-        entry.housenumber
-      else
-        split_address[2]
-      end
+      entry.housenumber
     end
 
     def peid
@@ -109,12 +101,5 @@ def phone_number(label)
     def additional_email(label)
       entry.additional_emails.find_by(label: label).try(:email)
     end
-
-    def split_address
-      FeatureGate.refute!("structured_addresses")
-
-      entry.address&.match(Address::FullTextSearch::ADDRESS_WITH_NUMBER_REGEX)&.to_a ||
-        [entry.address]
-    end
   end
 end

spec/features/event_register_managed_spec.rb

@@ -32,8 +32,6 @@
 
         context 'with feature toggle disabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(false)
@@ -50,8 +48,6 @@
 
         context 'with people_managers feature toggle enabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(true)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(false)
@@ -145,8 +141,6 @@
 
           context 'with feature toggle disabled' do
             before do
-              allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-              allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
               allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
               allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(true)
               allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(false)
@@ -161,8 +155,6 @@
 
           context 'with feature toggle enabled' do
             before do
-              allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-              allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
               allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
               allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(true)
               allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(true)
@@ -204,8 +196,6 @@
       describe 'registering new managed' do
         context 'with people_managers feature toggle disabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(false)
           end
@@ -241,8 +231,6 @@
 
         context 'with people_managers feature toggle enabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with(:self_registration_reason).and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(true)
           end

spec/features/external_event_register_manager_spec.rb

@@ -22,8 +22,6 @@
           allow(FeatureGate).to receive(:enabled?).with('groups.self_registration').and_return(false)
           allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(false)
           allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(true)
-          allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-          allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
           allow_any_instance_of(FeatureGate).to receive(:enabled?).and_return(false)
         end
 
@@ -58,15 +56,11 @@
           allow(FeatureGate).to receive(:enabled?).with('groups.self_registration').and_return(false)
           allow(FeatureGate).to receive(:enabled?).with('people.people_managers').and_return(true)
           allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(true)
-          allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-          allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
           allow_any_instance_of(FeatureGate).to receive(:enabled?).and_return(true)
         end
 
         context 'with self_service_managed_creation feature toggle disabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(false)
           end
 
@@ -79,8 +73,6 @@
 
         context 'with self_service_managed_creation feature toggle enabled' do
           before do
-            allow(FeatureGate).to receive(:enabled?).with('structured_addresses').and_return(true)
-            allow(FeatureGate).to receive(:enabled?).with('address_migration').and_return(false)
             allow(FeatureGate).to receive(:enabled?).with('people.people_managers.self_service_managed_creation').and_return(true)
           end
 

spec/jobs/export/event_participations_export_job_spec.rb

@@ -40,7 +40,7 @@
       lines = file.read.lines
       expect(lines.size).to eq(4)
       expect(lines[0]).to match(Regexp.new("^#{Export::Csv::UTF8_BOM}Vorname;Nachname"))
-      expect(lines[0].split(';').count).to match(16)
+      expect(lines[0].split(';').count).to match(19)
       expect(file.generated_file).to be_attached
     end
   end
@@ -66,7 +66,6 @@
     let(:params) { { filter: 'all', nds_camp: true } }
 
     it 'and saves it' do
-      expect(FeatureGate.enabled?('structured_addresses')).to be_truthy
       subject.perform
 
       lines = file.read.lines