Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate Profile type definition #1382

Closed
friedger opened this issue Oct 20, 2022 · 0 comments · Fixed by #1478
Closed

Remove duplicate Profile type definition #1382

friedger opened this issue Oct 20, 2022 · 0 comments · Fixed by #1478
Assignees
@janniks
Milestone
Q2-2023

Comments

@friedger
Copy link
Contributor

Describe the bug
Wallet-sdk defines a profile type. This should be part of @stacks/profile. With #1381 we then have two type definitions.

What version of Stacks.js are you using?
HEAD

Additional context
leather-io/extension#2632
@friedger friedger mentioned this issue Oct 20, 2022
Closed
5 tasks
@lgalabru lgalabru added this to DevTools Feb 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Feb 2, 2023
@janniks janniks moved this from 🆕 New to 🔖 To do in DevTools Feb 15, 2023
@janniks janniks mentioned this issue Apr 10, 2023
Merged
@janniks janniks moved this from 🔖 To do to 🏗 In progress in DevTools Apr 12, 2023
@janniks janniks moved this from 🏗 In progress to 👀 In review in DevTools Apr 12, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in DevTools Apr 28, 2023
@smcclellan smcclellan added this to the Q2-2023 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janniks janniks

Labels
None yet
Projects
DevTools
Archived in project
Milestone
Q2-2023
Development

Successfully merging a pull request may close this issue.

chore: remove duplicate profile definition hirosystems/stacks.js
3 participants
@friedger @janniks @smcclellan