-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] Stacking pox-2 #1354
[2.1] Stacking pox-2 #1354
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9a56486
to
72b2db5
Compare
35c32dd
to
eeaef5d
Compare
72b2db5
to
f82e623
Compare
Codecov Report
@@ Coverage Diff @@
## stacks-2.1 #1354 +/- ##
=============================================
Coverage ? 63.48%
=============================================
Files ? 116
Lines ? 8493
Branches ? 1877
=============================================
Hits ? 5392
Misses ? 2973
Partials ? 128 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@zone117x What's the best way to detect period-2 via API endpoints? e.g. Running |
IIRC, during period 2, |
dd57de4
to
cc0c50c
Compare
3e195b9
to
759342c
Compare
1d53808
to
632e363
Compare
@zone117x ready for another review
|
Noticed there was still incorrect Period definitions in there. 3 was basically 2b, now I added all periods and more explicit tests. ✅ |
a12d58d
to
50a78ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @janniks!
BREAKING CHANGE: Remove the getBTCAddress method, since it does not work with modern BTC addresses. A StackingClient will now automatically detect which PoX version to use for Stacking. Adds the following PoX Stacking methods to the StackingClient: `stackExtend`, `stackIncrease`, `delegateStackExtend`, `delegateStackIncrease`, `stackAggregationCommitIndexed`, `stackAggregationIncrease`. Adds the following helper methods to the StackingClient: `getAccountExtendedBalances`, `getAccountBalanceLocked`, `getDelegationStatus`, `getRewardSet`.
BREAKING CHANGE: Remove the getBTCAddress method, since it does not work with modern BTC addresses. A StackingClient will now automatically detect which PoX version to use for Stacking. Adds the following PoX Stacking methods to the StackingClient: `stackExtend`, `stackIncrease`, `delegateStackExtend`, `delegateStackIncrease`, `stackAggregationCommitIndexed`, `stackAggregationIncrease`. Adds the following helper methods to the StackingClient: `getAccountExtendedBalances`, `getAccountBalanceLocked`, `getDelegationStatus`, `getRewardSet`.
Methods for the upcoming @stacks/stacking changes to PoX-v2
@stacks/stacking
(PoX-2) #1347and payload modification, to avoid failing txsFor Follow-Up PRs:
poxContract
parameter to stacking methods, for users to choose specifically (semver compatible)