Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rusqlite and secp256k1 dependency #514

Closed
obycode opened this issue Aug 16, 2022 · 1 comment
Closed

Remove rusqlite and secp256k1 dependency #514

obycode opened this issue Aug 16, 2022 · 1 comment
Assignees
@lgalabru

Comments

@obycode
Copy link
Member

obycode commented Aug 16, 2022

After switching to the canonical VM, we have a dependency on rusqlite which will cause a problem with WASM builds. It is only needed for satisfying the ClarityBackingStore trait; see datastore.rs:169

    fn get_side_store(&mut self) -> &Connection {
        panic!("DataStore has no side store")
    }
@obycode obycode self-assigned this Aug 16, 2022
@obycode obycode mentioned this issue Aug 16, 2022
Merged
@lgalabru lgalabru added this to DevTools Sep 6, 2022
@lgalabru lgalabru moved this to 🆕 New in DevTools Sep 6, 2022
@lgalabru lgalabru moved this from 🆕 New to 🔖 To do in DevTools Sep 6, 2022
@lgalabru lgalabru moved this from 🔖 To do to 🆕 New in DevTools Sep 6, 2022
@lgalabru lgalabru moved this from 🆕 New to 🔖 To do in DevTools Sep 6, 2022
@hugocaillard hugocaillard changed the title Remove rusqlite dependency Remove rusqlite and secp256k1 dependency Sep 7, 2022
@lgalabru lgalabru assigned lgalabru and unassigned obycode Oct 4, 2022
@lgalabru
Copy link
Contributor

lgalabru commented Oct 4, 2022

Addressed with #544

@lgalabru lgalabru moved this from 🔖 To do to 👀 In review in DevTools Oct 4, 2022
@lgalabru lgalabru added the 1.0 label Oct 6, 2022
@lgalabru lgalabru closed this as completed Oct 7, 2022
Repository owner moved this from 👀 In review to ✅ Done in DevTools Oct 7, 2022
@lgalabru lgalabru removed this from DevTools Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgalabru lgalabru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgalabru @obycode