Add application emojis #1990
Merged
Add application emojis #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n application emoji
davfsa
requested changes
Aug 2, 2024
|
Really nice first pull request btw! Thanks for taking the time to work on this!! |
Thank you for the quick response! I will take a deep look at whats needing to change when I'm back at my pc but thanks for now! |
Co-authored-by: davfsa <[email protected]> Signed-off-by: Blaze <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Blaze <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Blaze <[email protected]>
Co-authored-by: davfsa <[email protected]> Signed-off-by: Blaze <[email protected]>
davfsa
reviewed
Aug 5, 2024
didnt knew that that would work thx Co-authored-by: davfsa <[email protected]> Signed-off-by: Blaze <[email protected]>
davfsa
reviewed
Aug 5, 2024
davfsa
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've added the needed rest functions for handling application emojis and created an
ApplicationEmojiclass.I didn't want to use either
CustomEmojiorKnownCustomEmojibecauseCustomEmojiis missing theuserfield andKnownCustomEmojihas aguild_idfield which i didn't want to mess with becauseKnownCustomEmojiis used for theCacheImpland i didn't want to mess up the caching somehow which uses theguild_id.It's my first time contributing to a big project and my first time using Github not only for personal use, so I'm open to critic or any tips
Checklist
noxand all the pipelines have passed.