Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display_name to PartialUser #1951

Merged
merged 8 commits into from
Jul 6, 2024
Merged

Add display_name to PartialUser #1951

merged 8 commits into from
Jul 6, 2024

Conversation

stefanlight8
Copy link
Contributor

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

None

davfsa
davfsa reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thanks a lot!

Just some documentation and tests improvements

hikari/users.py Outdated Show resolved Hide resolved
tests/hikari/test_users.py Outdated Show resolved Hide resolved
@davfsa davfsa added the enhancement New feature or request label Jun 30, 2024
stefanlight8 and others added 2 commits June 30, 2024 21:45
@stefanlight8 @davfsa
Update hikari/users.py
7b3ae47 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: stefanlight <[email protected]>
@stefanlight8 @davfsa
Update tests/hikari/test_users.py
bf3825f 
Co-authored-by: davfsa <[email protected]>
Signed-off-by: stefanlight <[email protected]>
@davfsa davfsa merged commit 0394729 into hikari-py:master Jul 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davfsa davfsa davfsa left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanlight8 @davfsa