ContractCallQuery does not expose ContractFunctionResult on error

[Nana-EC]

Problem

Unlike other queries ContractCallQuery can execute contract transaction logic even though it doesn't change state or get gossiped out.
As a result it's important to have more details regarding why a contract execution failed.
Currently the error details are limited to
{"name":"StatusError","status":"CONTRACT_REVERT_EXECUTED","transactionId":"[email protected]","message":"transaction [email protected] failed precheck with status CONTRACT_REVERT_EXECUTED"}

The network exposes this in the ContractFunctionResult which should be returned on all calls including failure as it includes the reason/error message.

It seems the java SDK exposes this but the logic is missing on the js version.
This results in eth devs who will predominately use the relay missing on the details they need to debug

Solution

Expose the ContractFunctionResult details on error.
Especially ContractFunctionResult.errorMessage
This will allow the relay to retrieve the information and pass it on to clients that submit contract call queries.

Alternatives

No response

[mehcode]

After digging into this in the other SDKs, I can say that no SDK currently implements this.

In order to not break backwards-compatibility, we can't start not throwing an exception on a pre-check failure (CONTRACT_REVERT_EXECUTED). I'm going to add a nullable property contractFunctionResult to https://github.com/hashgraph/hedera-sdk-js/blob/main/src/PrecheckStatusError.js#L28.

Usage example:

let result;

try {
  result = await new ContractCallQuery()
            .setContractId(contract)
            .setQueryPayment(new Hbar(5))
            .setGas(75000)
            .setFunction("getMessage")
            .execute(env.client);
} catch (error) {
  if (error instanceof PrecheckStatusError) {
    if (error.status === Status.ContractRevertExecuted) {
       // do something with: error.contractFunctionResult
    }
  }

  throw error;
}