Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Add tests to find undefined names #325

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 14, 2019

No description provided.

@request-info
Copy link

request-info bot commented Jul 14, 2019

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@LeoQuote
Copy link
Collaborator

Thanks for your contribution! I noticed that the build failed due to an obsolete module "Themis" of our project, I wonder if there's a way to add a config file for flake8 to ignore the whole "themis" directory?
Could you please do that so the build can pass?

@LeoQuote LeoQuote requested a review from hhyo July 15, 2019 03:33
@LeoQuote
Copy link
Collaborator

@hhyo 我好像没权限, 这个pr不知道怎么回事没有拿到覆盖率, 加个未定义变量应该问题不大, 应该可以合了, 后期看看应该可以加更多的静态代码检查

LGTM, but it seems I dont have permission to merge this since no coverage report been found, I've already requested the owner of project to deal with this.

@hhyo hhyo merged commit 621eb6c into hhyo:master Jul 15, 2019
@cclauss cclauss deleted the patch-1 branch July 15, 2019 03:48
xxlaila pushed a commit to xxlaila/Archery that referenced this pull request Feb 15, 2025
Travis CI: Add tests to find undefined names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants