-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all ZWJ sequences #96
Comments
Hi @carlinmack, many thanks for the investigation!
I believe it is simply a unicode data definition problem. For all the unicode definitions we have a hard dependency to
Yes these would be fun ... however I'm a bit hesitant to add even more new todos on our list, especially if they are outside of official unicode and no body has requested them. Happy to add them I you take care of them :) |
If they're not displaying correctly, would it not be all emoji in the first list? Or is it possible that some of these are our fault, like the families? |
|
We have baby emoji already so is it just a case of placing the glyphs together? |
Yes, but you might have to redesign the Baby emoji to reflect the small size of it in a Family combination and in addition get emojibase-data fixed to pull from it the related Unicode definitions. But I'm not sure whether emojibase-data would want to include it as it seems not to be part of the Unicode standard:
(https://emojipedia.org/family-woman-baby-boy/) If emojibase-data doesn't want to include it ... then I would rather vote currently against it. Too much effort for little gain on the big picture of OpenMoji. IMO more important is the soon upcoming Emoji 13 ... |
Yep Emoji 13 is on my radar but thought we'd deal with the font, consistency issues before I open an issue with 100 new unique glyphs haha |
I didn't realise microsoft was the only vendor supporting those family combinations! It may be the case that only the sporting ones are "widely" supported and are actually worth implementing - or maybe they're all microsoft specific! I would research but finals week 👨🎓👨🏫📝😥 |
@carlinmack Can we close this issue? It seems nobody is keen to support non-standard ZWJ variants. Plz :) The only ones in doubt are the wrestlers, see discussion in the emojibase repo. |
sure! |
Inspired by #95 we should aim to support all emoji "not listed as RGI (Recommended for General Interchange) by Unicode". https://emojipedia.org/emoji-zwj-sequences/
We should try display the emojis on that page and add the ones that display incorrectly to a listNot sure how valid this is but using the black openmoji font and vscode, it shows ones we support as a single character and others as multiple characters
However we do have a pirate flag emoji so maybe this is also an issue with the font that we haven't realised?
Erroneous ZWJ from the VS Code test:
Erroneous ZWJ from the VS Code test that we don't have designs for:
The text was updated successfully, but these errors were encountered: