added command line option output to write db.json and _multiconfig.…
#3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yml to a path provided
JLHwung
requested changes
Apr 17, 2018
| @@ -14,6 +15,22 @@ describe('config flag handling', () => { | |||
|
|
|||
| function ConsoleReader() { | |||
| this.reader = []; | |||
| this.d = function(...args) { | |||
| var type = 'debug'; | |||
There was a problem hiding this comment.
If the differences of this.d and this.i are only type, could you refactor into a factory so that
this.d = readerStub("debug")
this.i = readerStub("info")
Thanks.
There was a problem hiding this comment.
I was just copying the style of the existing code. I didn't want to touch to many lines. It's also a test case, not production code. If you want this refactored, change impact this.w and this.e which are below these changes in the same file.
If you'd like this refactored, let me know. Otherwise I'll leave it as it.
There was a problem hiding this comment.
@JLHwung bump.
JLHwung
approved these changes
Apr 25, 2018
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
hexojs#3122) * added command line option `output` to write db.json and _multiconfig.yml to a path provided * fixes for appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working with a read-only file system and I need a way to direct the output to a different path.
I added command line option
outputto write db.json and _multiconfig.yml to a path provided