Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toc): use escaped text to generate toc from heading #2898

Merged
merged 1 commit into from
Dec 11, 2017
Merged

fix(toc): use escaped text to generate toc from heading #2898

merged 1 commit into from
Dec 11, 2017
+11 −3

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Dec 9, 2017

Fixes #2896

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

cc @ahonn

@JLHwung JLHwung requested a review from NoahDragon December 9, 2017 04:30
@coveralls
Copy link

coveralls commented Dec 9, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling ef38893 on fix-2896 into dee3b03 on master.

NoahDragon
NoahDragon approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NoahDragon NoahDragon merged commit c8d47b8 into master Dec 11, 2017
@NoahDragon NoahDragon deleted the fix-2896 branch December 11, 2017 19:42
This was referenced Dec 11, 2017
Merged
Closed
@JLHwung JLHwung added this to the 3.4.4 milestone Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@JLHwung @coveralls @NoahDragon @chuxubank @dinghongkai