Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/spring-cloud-data-flow] Move chart to distributed bitnami repository #23295

Merged
merged 5 commits into from
Aug 31, 2020
Merged

[stable/spring-cloud-data-flow] Move chart to distributed bitnami repository #23295

merged 5 commits into from
Aug 31, 2020

Conversation

donbeave
Copy link
Contributor

What this PR does / why we need it:

Given the stable deprecation timeline, the Bitnami maintained Spring Cloud Data Flow Helm chart is now located at bitnami/charts.

Please, use this issue for common questions about the migration/deprecation process, for PR/Issues related to the chart itself, please visit the bitnami/charts GitHub repository.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot
Copy link
Contributor

Hi @donbeave. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2020
@donbeave
Copy link
Contributor Author

/assign @chrisjs

@donbeave
Copy link
Contributor Author

/assign @sabbyanandan

@mattfarina
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020
@mattfarina
Copy link
Contributor

/cc @trisberg @chrisjs @sabbyanandan

@k8s-ci-robot
Copy link
Contributor

@mattfarina: GitHub didn't allow me to request PR reviews from the following users: trisberg.

Note that only helm members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @trisberg @chrisjs @sabbyanandan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2020
@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2020
@chrisjs
Copy link
Collaborator

chrisjs commented Aug 26, 2020

@donbeave sorry for the delay, we are ready to move forward on this. if you would like to update the conflict we can push this going again

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2020
@donbeave
Copy link
Contributor Author

@chrisjs conflicts resolved

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2020
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2020
chrisjs
chrisjs suggested changes Aug 27, 2020
View reviewed changes
stable/spring-cloud-data-flow/README.md Outdated
@@ -4,6 +4,27 @@

Data processing pipelines consist of [Spring Boot](https://projects.spring.io/spring-boot/) apps, built using the [Spring Cloud Stream](https://cloud.spring.io/spring-cloud-stream/) or [Spring Cloud Task](https://cloud.spring.io/spring-cloud-task/) microservice frameworks. This makes Spring Cloud Data Flow suitable for a range of data processing use cases, from import/export to event streaming and predictive analytics.

## This Helm chart is deprecated

Given the [`stable` deprecation timeline](https://github.com/helm/charts#deprecation-timeline), the Bitnami maintained Redis Helm chart is now located at [bitnami/charts](https://github.com/bitnami/charts/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis -> Spring Cloud Data Flow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for this. Fixed.

stable/spring-cloud-data-flow/templates/NOTES.txt Outdated
@@ -1,3 +1,23 @@
This Helm chart is deprecated

Given the `stable` deprecation timeline (https://github.com/helm/charts#deprecation-timeline), the Bitnami maintained Redis Helm chart is now located at bitnami/charts (https://github.com/bitnami/charts/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis -> Spring Cloud Data Flow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@donbeave
Typo.
6d195fa 
Signed-off-by: Alexey Zhokhov <[email protected]>
@donbeave donbeave requested a review from chrisjs August 29, 2020 18:32
@chrisjs
Copy link
Collaborator

chrisjs commented Aug 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisjs, donbeave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7bab8b5 into helm:master Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattfarina mattfarina mattfarina left review comments

@sabbyanandan sabbyanandan Awaiting requested review from sabbyanandan

@chrisjs chrisjs Awaiting requested review from chrisjs

Assignees

@chrisjs chrisjs

@sabbyanandan sabbyanandan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@donbeave @k8s-ci-robot @mattfarina @chrisjs @sabbyanandan @helm-bot