-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/unifi] Add ingress for Unifi controller sevice #22703
[stable/unifi] Add ingress for Unifi controller sevice #22703
Conversation
Hi @stephenliang. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @billimek |
/ok-to-test |
Thanks @stephenliang for this PR! Do you mind bumping the chart version to |
89b3717
to
f3d0d1e
Compare
Makes sense, I bumped the version to 0.9.0 |
Thanks @stephenliang. There was another merge of this chart, so can you please rebase with the master branch? The Chart.yaml version will need to be bumped again too - I suggest using |
…rvice. Fixes helm#21887 Bump version to 0.10.0 Signed-off-by: Stephen Liang <[email protected]>
f3d0d1e
to
dcc688f
Compare
Sounds good @billimek I bumped it to 0.10.0 and rebased it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, stephenliang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rvice. (helm#22703) Fixes helm#21887 Bump version to 0.10.0 Signed-off-by: Stephen Liang <[email protected]>
…rvice. (helm#22703) Fixes helm#21887 Bump version to 0.10.0 Signed-off-by: Stephen Liang <[email protected]>
…rvice. (helm#22703) Fixes helm#21887 Bump version to 0.10.0 Signed-off-by: Stephen Liang <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
…rvice. (helm#22703) Fixes helm#21887 Bump version to 0.10.0 Signed-off-by: Stephen Liang <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
Signed-off-by: Stephen Liang [email protected]
Is this a new chart
No.
What this PR does / why we need it:
Adds an ingress for the Unifi HTTP-only controller "/inform" path. Without this change, the standard controller would attempt to pass to "/inform" using TLS and since the inform path is HTTP only, will fail.
In addition, in the unified service mode specified in this helm chart, an external load balancer could be used to specify a port to the controller service, however without an external load balancer, an ingress to the controller would be needed.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
@billimek @mcronce
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)