Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/unifi] adding functionality to mount extra volumes #22702

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

miwinski
Copy link
Contributor

@miwinski miwinski commented Jun 7, 2020

Is this a new chart

existing chart [stable/unifi]

What this PR does / why we need it:

This PR allows to specify additional volumes to be mounted to unifi container during deployment of Unifi Controller. So for example - my environment is using a single
Unifi switch between my k8s cluster and my NAS (volumes are exposed via iSCSI). If I use persistence.existingClaim=iscsi-pvc-for-unifi and during normal operations of Unifi I do
a firmware upgrade of that switch I'm disrupting connectivity between Unifi Controller
and remote storage potentially causing corruption of controller's database stored on remote
volume. With this PR I can specify persistence.existingClaim=unifi-pvc-on-local-node-disk which will allow me to rebuild/upgrade Controller POD without loosing data and mount additional remote volume for example a backup dir. This way I only store backups on remote drive and a short network disruption doesn't have that big impact on Unifi controller.
Another benefit of this PR is that it also allows to specify another extra volume and mount a configmap serving a custom config.gatewy.json.

Which issue this PR fixes

No issue reported for this feature

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

This change adds possibility to specify additional volumes
when deploying Unifi controller.

Signed-off-by: Marcin Iwinski <[email protected]>
@k8s-ci-robot k8s-ci-robot requested review from billimek and mcronce June 7, 2020 15:02
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @iwwwwwwi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miwinski
Copy link
Contributor Author

miwinski commented Jun 7, 2020

/assign @billimek

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 7, 2020
Signed-off-by: Marcin Iwinski <[email protected]>
@miwinski miwinski force-pushed the miwinski/unifi/extraVolumes branch from af1ea4c to 7106c1f Compare June 7, 2020 15:19
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 7, 2020
@billimek
Copy link
Collaborator

billimek commented Jun 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2020
@billimek
Copy link
Collaborator

billimek commented Jun 7, 2020

Hi @iwwwwwwi. Thanks for the PR!

Do you mind bumping the chart version to 0.9.0 as there is a new feature being added?

@miwinski
Copy link
Contributor Author

miwinski commented Jun 8, 2020

@billimek bumped version to 0.9.0

@billimek
Copy link
Collaborator

billimek commented Jun 8, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: billimek, iwwwwwwi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit bf13f94 into helm:master Jun 8, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
* [stable/unifi] adding functionality to mount extra volumes

This change adds possibility to specify additional volumes
when deploying Unifi controller.

Signed-off-by: Marcin Iwinski <[email protected]>

* fixing defaults in README.md

Signed-off-by: Marcin Iwinski <[email protected]>

* [stable/unifi] bumping version to 0.9.0

Signed-off-by: Marcin Iwinski <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
* [stable/unifi] adding functionality to mount extra volumes

This change adds possibility to specify additional volumes
when deploying Unifi controller.

Signed-off-by: Marcin Iwinski <[email protected]>

* fixing defaults in README.md

Signed-off-by: Marcin Iwinski <[email protected]>

* [stable/unifi] bumping version to 0.9.0

Signed-off-by: Marcin Iwinski <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
* [stable/unifi] adding functionality to mount extra volumes

This change adds possibility to specify additional volumes
when deploying Unifi controller.

Signed-off-by: Marcin Iwinski <[email protected]>

* fixing defaults in README.md

Signed-off-by: Marcin Iwinski <[email protected]>

* [stable/unifi] bumping version to 0.9.0

Signed-off-by: Marcin Iwinski <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
* [stable/unifi] adding functionality to mount extra volumes

This change adds possibility to specify additional volumes
when deploying Unifi controller.

Signed-off-by: Marcin Iwinski <[email protected]>

* fixing defaults in README.md

Signed-off-by: Marcin Iwinski <[email protected]>

* [stable/unifi] bumping version to 0.9.0

Signed-off-by: Marcin Iwinski <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants