-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/unifi] adding functionality to mount extra volumes #22702
[stable/unifi] adding functionality to mount extra volumes #22702
Conversation
This change adds possibility to specify additional volumes when deploying Unifi controller. Signed-off-by: Marcin Iwinski <[email protected]>
Hi @iwwwwwwi. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @billimek |
Signed-off-by: Marcin Iwinski <[email protected]>
af1ea4c
to
7106c1f
Compare
/ok-to-test |
Hi @iwwwwwwi. Thanks for the PR! Do you mind bumping the chart version to |
Signed-off-by: Marcin Iwinski <[email protected]>
@billimek bumped version to 0.9.0 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, iwwwwwwi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [stable/unifi] adding functionality to mount extra volumes This change adds possibility to specify additional volumes when deploying Unifi controller. Signed-off-by: Marcin Iwinski <[email protected]> * fixing defaults in README.md Signed-off-by: Marcin Iwinski <[email protected]> * [stable/unifi] bumping version to 0.9.0 Signed-off-by: Marcin Iwinski <[email protected]>
* [stable/unifi] adding functionality to mount extra volumes This change adds possibility to specify additional volumes when deploying Unifi controller. Signed-off-by: Marcin Iwinski <[email protected]> * fixing defaults in README.md Signed-off-by: Marcin Iwinski <[email protected]> * [stable/unifi] bumping version to 0.9.0 Signed-off-by: Marcin Iwinski <[email protected]>
* [stable/unifi] adding functionality to mount extra volumes This change adds possibility to specify additional volumes when deploying Unifi controller. Signed-off-by: Marcin Iwinski <[email protected]> * fixing defaults in README.md Signed-off-by: Marcin Iwinski <[email protected]> * [stable/unifi] bumping version to 0.9.0 Signed-off-by: Marcin Iwinski <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
* [stable/unifi] adding functionality to mount extra volumes This change adds possibility to specify additional volumes when deploying Unifi controller. Signed-off-by: Marcin Iwinski <[email protected]> * fixing defaults in README.md Signed-off-by: Marcin Iwinski <[email protected]> * [stable/unifi] bumping version to 0.9.0 Signed-off-by: Marcin Iwinski <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
Is this a new chart
existing chart [stable/unifi]
What this PR does / why we need it:
This PR allows to specify additional volumes to be mounted to unifi container during deployment of Unifi Controller. So for example - my environment is using a single
Unifi switch between my k8s cluster and my NAS (volumes are exposed via iSCSI). If I use
persistence.existingClaim=iscsi-pvc-for-unifi
and during normal operations of Unifi I doa firmware upgrade of that switch I'm disrupting connectivity between Unifi Controller
and remote storage potentially causing corruption of controller's database stored on remote
volume. With this PR I can specify
persistence.existingClaim=unifi-pvc-on-local-node-disk
which will allow me to rebuild/upgrade Controller POD without loosing data and mount additional remote volume for example a backup dir. This way I only store backups on remote drive and a short network disruption doesn't have that big impact on Unifi controller.Another benefit of this PR is that it also allows to specify another extra volume and mount a configmap serving a custom config.gatewy.json.
Which issue this PR fixes
No issue reported for this feature
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)