Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/buzzfeed-sso] Add support for GCP BackendConfig #22148

Merged
merged 3 commits into from
Jun 7, 2020
Merged

[incubator/buzzfeed-sso] Add support for GCP BackendConfig #22148

merged 3 commits into from
Jun 7, 2020

Conversation

anas-aso
Copy link
Contributor

Is this a new chart

No

What this PR does / why we need it:

To be able to configure GCP LB backend service (e.g timeouts) for applications behind buzzfeed-sso Proxy.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot
Copy link
Contributor

Hi @anas-aso. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2020
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2020
@anas-aso
Copy link
Contributor Author

/assign @darioblanco

@anas-aso
Copy link
Contributor Author

@darioblanco @komljen can I have your reviews for this PR please ?

@anas-aso
Copy link
Contributor Author

@darioblanco @komljen any chance in reviewing this PR ?

@anas-aso
Copy link
Contributor Author

/assign @komljen

@zanhsieh
Copy link
Collaborator

zanhsieh commented Jun 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2020
darioblanco
darioblanco approved these changes Jun 7, 2020
View reviewed changes
Copy link
Collaborator

@darioblanco darioblanco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry for the delay

@darioblanco
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anas-aso, darioblanco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 7, 2020
@darioblanco
Copy link
Collaborator

@anas-aso sorry this one took so long. I am available in the #charts channel in the Kubernetes Slack space if I am not reacting to an assignment. I totally overlooked it.

@k8s-ci-robot k8s-ci-robot merged commit 80cf705 into helm:master Jun 7, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@anas-aso
[incubator/buzzfeed-sso] Add support for GCP BackendConfig (helm#22148)
eb8ace5 
* Add support for GCP BackendConfig.

Signed-off-by: Anas <[email protected]>

* Bump chart version.

Signed-off-by: Anas <[email protected]>

* Document new variable.

Signed-off-by: Anas <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@anas-aso @includerandom
[incubator/buzzfeed-sso] Add support for GCP BackendConfig (helm#22148)
61aa998 
* Add support for GCP BackendConfig.

Signed-off-by: Anas <[email protected]>

* Bump chart version.

Signed-off-by: Anas <[email protected]>

* Document new variable.

Signed-off-by: Anas <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@anas-aso @li-adrienloiseau
[incubator/buzzfeed-sso] Add support for GCP BackendConfig (helm#22148)
a870603 
* Add support for GCP BackendConfig.

Signed-off-by: Anas <[email protected]>

* Bump chart version.

Signed-off-by: Anas <[email protected]>

* Document new variable.

Signed-off-by: Anas <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@anas-aso
[incubator/buzzfeed-sso] Add support for GCP BackendConfig (helm#22148)
fd0874c 
* Add support for GCP BackendConfig.

Signed-off-by: Anas <[email protected]>

* Bump chart version.

Signed-off-by: Anas <[email protected]>

* Document new variable.

Signed-off-by: Anas <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darioblanco darioblanco darioblanco approved these changes

@komljen komljen Awaiting requested review from komljen

Assignees

@darioblanco darioblanco

@komljen komljen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anas-aso @k8s-ci-robot @zanhsieh @darioblanco @komljen @helm-bot