Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/stackdriver-exporter] update k8s deployement api version #21720

Merged
merged 2 commits into from
Jun 6, 2020
Merged

[stable/stackdriver-exporter] update k8s deployement api version #21720

merged 2 commits into from
Jun 6, 2020

Conversation

jordanabderrachid
Copy link
Contributor

@jordanabderrachid jordanabderrachid commented Apr 2, 2020 •
edited
Loading

As of v1.16, k8s won't accept a deployment with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

@apenney

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@jordanabderrachid
[stable/stackdriver-exporter] update k8s deployement api version
5aaaf33 
As of v1.16, k8s won't accept a deploymement with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Signed-off-by: Jordan Abderrachid <[email protected]>
@jordanabderrachid
bump chart version to 1.2.3
0e33048 
Signed-off-by: Jordan Abderrachid <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jordanabderrachid. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2020
@k8s-ci-robot k8s-ci-robot requested review from cpanato and paulczar April 2, 2020 09:35
@jordanabderrachid
Copy link
Contributor Author

/assign @viglesiasce

@cpanato
Copy link
Member

cpanato commented Apr 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2020
@stale
Copy link

stale bot commented May 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2020
@jordanabderrachid
Copy link
Contributor Author

Hey @paulczar @cpanato @viglesiasce sorry not really sure what the process is to get it reviewed? :))

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2020
@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
@AronllStone
Copy link

Hey @paulczar @cpanato @viglesiasce
Could you review this PR, please?
This feature is really needed on 1.16 and more version of K8s
Thank you! :)

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
cpanato
cpanato approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jordanabderrachid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit fd82c27 into helm:master Jun 6, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@jordanabderrachid
[stable/stackdriver-exporter] update k8s deployement api version (hel…
9432857 
…m#21720)

* [stable/stackdriver-exporter] update k8s deployement api version

As of v1.16, k8s won't accept a deploymement with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Signed-off-by: Jordan Abderrachid <[email protected]>

* bump chart version to 1.2.3

Signed-off-by: Jordan Abderrachid <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@jordanabderrachid @includerandom
[stable/stackdriver-exporter] update k8s deployement api version (hel…
e486f12 
…m#21720)

* [stable/stackdriver-exporter] update k8s deployement api version

As of v1.16, k8s won't accept a deploymement with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Signed-off-by: Jordan Abderrachid <[email protected]>

* bump chart version to 1.2.3

Signed-off-by: Jordan Abderrachid <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@jordanabderrachid @li-adrienloiseau
[stable/stackdriver-exporter] update k8s deployement api version (hel…
4fde7ee 
…m#21720)

* [stable/stackdriver-exporter] update k8s deployement api version

As of v1.16, k8s won't accept a deploymement with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Signed-off-by: Jordan Abderrachid <[email protected]>

* bump chart version to 1.2.3

Signed-off-by: Jordan Abderrachid <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@jordanabderrachid
[stable/stackdriver-exporter] update k8s deployement api version (hel…
bf70778 
…m#21720)

* [stable/stackdriver-exporter] update k8s deployement api version

As of v1.16, k8s won't accept a deploymement with apps/v1beta1
or apps/v1beta2 apiVersion. The accepted apiVersion is apps/v1
that is available since k8s v1.9.

See https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

Signed-off-by: Jordan Abderrachid <[email protected]>

* bump chart version to 1.2.3

Signed-off-by: Jordan Abderrachid <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

@paulczar paulczar Awaiting requested review from paulczar

Assignees

@viglesiasce viglesiasce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jordanabderrachid @k8s-ci-robot @cpanato @AronllStone @viglesiasce @helm-bot