:quit panic

[robinvd]

Reproduction steps

Hard to reproduce, but in using helix i've had it multiple times.

1. run the :quit command
2. see the error

thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', helix-lsp/src/transport.rs:100:45
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Environment

• Platform: linux
• Helix version: v0.0.10-66-g9baf1ec

[archseer]

I'm guessing the LSP terminates early and the receive loop fails. We probably want to send proper shutdown signals to LSPs before exiting. I suspect this is also the cause of #266 (also \cc-ing @batonius for thoughts, they've cleaned up a bunch of other panics in that crate)

A quick fix would be

helix/helix-lsp/src/transport.rs

Line 100 in d1c8a74

let content_length = content_length.unwrap();

and

helix/helix-lsp/src/transport.rs

Line 105 in d1c8a74

let msg = String::from_utf8(content).unwrap();

replacing .unwrap() with ? so we don't panic.

(Sidenote: your Helix version seems to be different, it's still on 0.0.10 but contains new commits)

[archseer]

Can you still reproduce this with #287 merged?

[robinvd]

Ill test it for a while, and report back.