Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More scopes for theme-ing + Fix request #1831

Closed
zuixalias opened this issue Mar 18, 2022 · 6 comments
Closed

More scopes for theme-ing + Fix request #1831

zuixalias opened this issue Mar 18, 2022 · 6 comments
Labels
C-enhancement Category: Improvements

Comments

@zuixalias
Copy link

zuixalias commented Mar 18, 2022

Maybe add more scopes for detailed/ a bit better theming...hehe.

[ FIX REQUEST (For C#, not sure of other lang right now) ]
As shown in the picture,

  • Some function names are not rendered with correct color (ones that contain the language inbuilt data types before them) and inside the function, the called function names also don't have colors
  • keyword.control colors are not applied to C# (not sure for other langs, for rust they have correct color)

There could be more, i will update as i explore helix, lol.

view

@zuixalias zuixalias added the C-enhancement Category: Improvements label Mar 18, 2022
@archseer
Copy link
Member

This is all up to the highlighting queries for each language. You can make improvements to https://github.com/helix-editor/helix/blob/master/runtime/queries/c-sharp/highlights.scm

@archseer
Copy link
Member

For example some languages just use keyword and don't offer keyword.control

@archseer
Copy link
Member

You also didn't specify what helix version you're running. There was a recent PR: #1795

@zuixalias
Copy link
Author

zuixalias commented Mar 18, 2022

Ohh! That solves it!
I am using v0.6.0
You see, i am new to github, so i am not sure how to get that version 😅 (I am guessing i need to build helix from source?) (I tried but build fails with some header file not found error)

Edit: Nevermind...i will wait for another release :)

@archseer
Copy link
Member

hx -v will show you the current version

@archseer
Copy link
Member

Closed by #1795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants