Renaming rust modules

[mydumpfire]

Performing a rename on mod foobar or use foobar seems to rename the associated files, but not the references to it.

So if you have something like:

.
├── foobar.rs
├── lib.rs
└── main.rs

lib.rs:

pub mod foobar;

main.rs:

use my_lib::foobar;

Renaming the symbol foobar to baz will cause a file change:

.
├── baz.rs
├── lib.rs
└── main.rs

But all the references in the code stay the same:

lib.rs:

pub mod foobar;

I've tested this on VSCode (using the same toolchain) and it works as expected. But I don't think this is an LSP extension AFAIK. Interestingly, using the new :move command renames everything correctly.

[the-mikedavis]

This should be reported against rust-analyzer instead - rust-analyzer should be sending changes to that update the references.

[pascalkuthe]

The differences to vscode are likely caused by version mismatch. I even recently submitted related bugfixes upstream so if vscode is using the latest nightly and helix is using stable that would likely explain it

[mydumpfire]

Like I said in the post, I'm using the same toolchain that I used for Helix in VSCode. I've also tested this on neovim and renaming works correctly. I'm not sure what helix is doing differently here.

[mydumpfire]

To make it clearer, this is my setup:
helix: b7f98d1
rust: 1.76.0-nightly (9b13310ca 2023-11-24)

I'd appreciate it if you can at least reproduce this bug.

[archseer]

But what's your rust analyzer version? vscode installs and manages it's own install usually.

[mydumpfire]

I'm using the rust-analyzer that comes with the toolchain:
rust-analyzer 1.76.0-nightly (6cf0888 2023-11-26)
I've configured VSCode to use the same set of toolchain (verified with ps). Neovim also works correctly, btw (with the same toolchain of course).

[the-mikedavis]

Ah ok, I can reproduce this on rust-analyzer's current master (c7c582afb57bb802715262d7f1ba73b8a86c1c5a).

When we send the rename, rust-analyzer gives us only a resource operation to rename the file.

2023-11-28T18:26:24.400 helix_lsp::transport [INFO] rust-analyzer -> {"jsonrpc":"2.0","method":"textDocument/rename","params":{"newName":"baz","position":{"character":11,"line":0},"textDocument":{"uri":"file:///home/michael/tmp/src/main.rs"}},"id":2}
2023-11-28T18:26:24.401 helix_lsp::transport [INFO] rust-analyzer <- {"jsonrpc":"2.0","id":2,"result":{"documentChanges":[{"kind":"rename","oldUri":"file:///home/michael/tmp/src/foobar.rs","newUri":"file:///home/michael/tmp/src/baz.rs"}]}}

While Neovim gets a whole set of edits including the file rename operation:

[DEBUG][2023-11-28 18:47:31] .../vim/lsp/rpc.lua:284	"rpc.send"	{  id = 7,  jsonrpc = "2.0",  method = "textDocument/rename",  params = {    newName = "baz",    position = {      character = 11,      line = 0    },    textDocument = {      uri = "file:///home/michael/tmp/src/main.rs"    }  }}
[DEBUG][2023-11-28 18:47:31] .../vim/lsp/rpc.lua:387	"rpc.receive"	{  id = 7,  jsonrpc = "2.0",  result = {    documentChanges = { {        edits = { {            newText = "baz",            range = {              ["end"] = {                character = 15,                line = 0              },              start = {                character = 9,                line = 0              }            }          } },        textDocument = {          uri = "file:///home/michael/tmp/src/main.rs",          version = 0        }      }, {        edits = { {            newText = "baz",            range = {              ["end"] = {                character = 14,                line = 0              },              start = {                character = 8,                line = 0              }            }          } },        textDocument = {          uri = "file:///home/michael/tmp/src/lib.rs"        }      }, {        kind = "rename",        newUri = "file:///home/michael/tmp/src/baz.rs",        oldUri = "file:///home/michael/tmp/src/foobar.rs"      } }  }}

Neovim doesn't declare willRename support in its capabilities so it gets a different set of edits from rust-analyzer. If you comment this line:

helix/helix-lsp/src/client.rs

Line 562 in b023faa

will_rename: Some(true),

then Helix and nvim behave the same.

Since we declare willRename support, we need to use it to handle rename resource operations from text document edits. I'll add an issue with the details. (#8942)