Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad practice in archetype project #6520

Closed
danielkec opened this issue Mar 30, 2023 · 0 comments · Fixed by #6558
Closed

Bad practice in archetype project #6520

danielkec opened this issue Mar 30, 2023 · 0 comments · Fixed by #6558
Assignees
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Milestone

Comments

@danielkec
Copy link
Contributor

Environment Details

  • Helidon Version: 3.x
  • Helidon SE

Problem Description

Tests with webclient should always use reactive operators forSingle, await with timeout

    @Test
    void testPokemonTypes() throws ExecutionException, InterruptedException {
        webClient.get()
                .path("/type")
                .request(JsonArray.class)
                .thenAccept(array -> {
                    assertThat(array.size(), is(18));
                    assertThat(array.get(0).asJsonObject().getInt("{{id}}"), is(1));
                    assertThat(array.get(0).asJsonObject().getString("{{name}}"), is("Normal"));
                })
                .toCompletableFuture()
                .get();
    }
@m0mus m0mus added P3 P2 bug Something isn't working and removed P3 labels Apr 3, 2023
@barchetta barchetta added the 3.x Issues for 3.x version branch label Apr 6, 2023
@barchetta barchetta added this to the 3.2.1 milestone Apr 6, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants