Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nima: ReadableEntityBase #5388

Closed
Tracked by #4766
tomas-langer opened this issue Nov 13, 2022 · 1 comment · Fixed by #6501
Closed
Tracked by #4766

Nima: ReadableEntityBase #5388

tomas-langer opened this issue Nov 13, 2022 · 1 comment · Fixed by #6501
Assignees
@arjav-desai
Labels
4.x Version 4.x Níma Helidon Níma task To do
Milestone
4.0.0-M1

Comments

@tomas-langer
Copy link
Member

tomas-langer commented Nov 13, 2022 •
edited
Loading

HTTP media - ReadableEntityBase TODO
@tomas-langer tomas-langer mentioned this issue Nov 13, 2022
Closed
62 tasks
@tomas-langer tomas-langer changed the title HTTP media - ReadableEntityBase TODO Nima: ReadableEntityBase Nov 13, 2022
@tomas-langer tomas-langer added task To do 4.x Version 4.x Níma Helidon Níma labels Nov 13, 2022
@tomas-langer tomas-langer added this to the 4.0.0-M1 milestone Nov 13, 2022
@arjav-desai arjav-desai mentioned this issue Mar 28, 2023
Merged
@barchetta barchetta modified the milestones: 4.0.0-ALPHA6, 4.0.0-M1 Apr 6, 2023
@arjav-desai
Copy link
Member

There is already an auto drain in place in Http1Connection.consumeEntity. See https://github.com/helidon-io/helidon/blob/main/nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/http1/Http1Connection.java#L341

So just removing the comment as we don’t need to do anything is this case.

@arjav-desai arjav-desai linked a pull request Jun 29, 2023 that will close this issue
Fix TODO to handle close call on entity #6501
Merged
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjav-desai arjav-desai

Labels
4.x Version 4.x Níma Helidon Níma task To do
Projects
Backlog
Archived in project
Milestone
4.0.0-M1
Development

Successfully merging a pull request may close this issue.

Fix TODO to handle close call on entity arjav-desai/helidon
3 participants
@barchetta @tomas-langer @arjav-desai