-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SE and MP guides to adopt new review feedback #176
Comments
@romain-grecourt @barchetta FYI some bad news...It turns out that GitHub does not support the AsciiDoc The issue makes a reference to perhaps being available "next year" (2019). |
@tjquinno That's fine with me :D - I actually would prefer linking the pre-req ; it does not make the guide self contained but makes it lighter. It goes against the rule of "links are bad", but we could be smart and have a little section at the top like "before you begin" where we list the things that must be done before following a guide. |
I'm not so concerned with the pre-requisites. The current guides pull in a great deal of code from the source (see the We can still move the .adoc files to |
Yikes, I missed that. One other way would be to not use the include directives at all but instead duplicate the content. The duplication sucks, it means we'd loose the advantages of using the include directives. This sounds like a potential good idea, we could also be smart and fix the indentation issues we get with the include directives. |
Yes, I was wondering what our options might be to do something like that. About the indentation with |
Romain and Joe supplied some good feedback about the first guide. This task incorporates that feedback into the first guide.
This is important to do now so future guides can use the SE RESTful web app one as a pattern.
Here is my list of the topics we covered:
a. Maybe a simple approach is for the common AsciiDoc attribute assignment file to assign attributes containing pre-req versions so the guide .adoc files can refer to those.
b. Another approach would be for the existing pre-reqs info in the Getting Started file to be tagged so individual guides can include only the pre-reqs they need.
The text was updated successfully, but these errors were encountered: