Skip to content

Commit 1172bc4

Browse files
committed
Merge bitcoin-core#850: psbt: Use SIGHASH_DEFAULT when signing PSBTs
3e97ff9 gui, psbt: Use SIGHASH_DEFAULT when signing PSBTs (Ava Chow) Pull request description: SIGHASH_DEFAULT should be used to indicate SIGHASH_DEFAULT for taproot inputs, and SIGHASH_ALL for all other input types. This avoids adding an unnecessary byte to the end of all Taproot signatures added to PSBTs signed in the GUI. See also bitcoin/bitcoin#22514 ACKs for top commit: Sjors: utACK 3e97ff9 pablomartin4btc: utACK 3e97ff9 hebasto: ACK 3e97ff9, I have reviewed the code and it looks OK. Tree-SHA512: f96f26b3a6959865cf23039afb5ffb7e454fb52ee39c510583851caf00a8a383cde69bc7e90db536addbdd498a02f4b001cbaf509d6d53c5f8601b3933786f6c
2 parents 85f96b0 + 3e97ff9 commit 1172bc4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/qt/psbtoperationsdialog.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ void PSBTOperationsDialog::signTransaction()
8383

8484
WalletModel::UnlockContext ctx(m_wallet_model->requestUnlock());
8585

86-
const auto err{m_wallet_model->wallet().fillPSBT(SIGHASH_ALL, /*sign=*/true, /*bip32derivs=*/true, &n_signed, m_transaction_data, complete)};
86+
const auto err{m_wallet_model->wallet().fillPSBT(SIGHASH_DEFAULT, /*sign=*/true, /*bip32derivs=*/true, &n_signed, m_transaction_data, complete)};
8787

8888
if (err) {
8989
showStatus(tr("Failed to sign transaction: %1")

0 commit comments

Comments
 (0)