Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders' replication fails #722

Closed
reggie7 opened this issue Feb 1, 2021 · 5 comments
Closed

Folders' replication fails #722

reggie7 opened this issue Feb 1, 2021 · 5 comments

Comments

@reggie7
Copy link
Contributor

reggie7 commented Feb 1, 2021

Assets console allows folders to be added to the structure, but default system settings prevent them from replication - one always gets Action timed out when publishing. We could simply add sling:OrderedFolder + sling:Folder + nt:folder to ReplicationMixinNodeTypesOverride, but this might cause unwanted side effects elsewhere.
Same applies to tags, though there is another UI/UX related inconsistency there.

@reusr1
Copy link
Contributor

reusr1 commented Feb 1, 2021

@reggie7 seems to me we should all discuss what a folder replication would mean - if the folder replication just creates the subfolder on the target I am not sure how much value it is to the user. On the other hand we also do not have folder properties at the moment nor are we allowing for folders to be deep replicated?

@cmrockwell you also may have some opinions about this topic?

@reggie7
Copy link
Contributor Author

reggie7 commented Feb 1, 2021

@reusr1 yes, let's discuss it. I say we either figure out together what it would mean to replicate a folder or we simply do not display the respective icon for the operation.

@ehdatheadwire
Copy link
Collaborator

Assuming that this is not required for 1.0.0 release and will involve more discussion, I'm marking it as "move" rather than just relocating it in case I'm incorrect in my assumption.

@ehdatheadwire ehdatheadwire added the scrubbed Ticket has been reviewed and assessed label Mar 13, 2021
@reusr1
Copy link
Contributor

reusr1 commented Mar 13, 2021

@ehdatheadwire decision needs to be made if we can publish folders in assets or not and around the UX for this.

options:

  • publishing a folder publishes all its children assets, optionally all the assets in child folders recursively)
  • publishing a folder is not allowed and the UI has to be updated to reflect that

note: we also have to define the behavior for unpublish at the same time

for simplicity:

  • I think its best to create an enhacement ticket on publishing/unpublishing trees (pages, assets, objects, templates, ...)
  • move this ticket forward by disabling the publishing of folders in assets (should probably be a new ticket and this ticket can be closed)

@ehdatheadwire
Copy link
Collaborator

New issue created in enhancements: peregrine-cms/enhancements#62.

New ticket created for disabling publishing of folders in assets here: #790

@ehdatheadwire ehdatheadwire removed the scrubbed Ticket has been reviewed and assessed label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants