From cef5006e4f4d4bc9adf70d73746e0aec61eca637 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 24 Apr 2023 22:15:26 -0500 Subject: [PATCH 1/3] docs: Make more resilient across rust versions --- src/builder/value_parser.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/builder/value_parser.rs b/src/builder/value_parser.rs index 92cbbadf8d8..cfe1e4dbfa3 100644 --- a/src/builder/value_parser.rs +++ b/src/builder/value_parser.rs @@ -2104,10 +2104,8 @@ pub mod via_prelude { /// assert_eq!(format!("{:?}", parser), "ValueParser::os_string"); /// let parser = clap::value_parser!(std::path::PathBuf); /// assert_eq!(format!("{:?}", parser), "ValueParser::path_buf"); -/// let parser = clap::value_parser!(u16).range(3000..); -/// assert_eq!(format!("{:?}", parser), "RangedI64ValueParser { bounds: (Included(3000), Included(65535)), target: PhantomData }"); -/// let parser = clap::value_parser!(u64).range(3000..); -/// assert_eq!(format!("{:?}", parser), "RangedU64ValueParser { bounds: (Included(3000), Unbounded), target: PhantomData }"); +/// let _parser = clap::value_parser!(u16).range(3000..); +/// let _parser = clap::value_parser!(u64).range(3000..); /// /// // FromStr types /// let parser = clap::value_parser!(usize); @@ -2133,8 +2131,7 @@ pub mod via_prelude { /// # } /// # } /// } -/// let parser = clap::value_parser!(ColorChoice); -/// assert_eq!(format!("{:?}", parser), "EnumValueParser(PhantomData)"); +/// let _parser = clap::value_parser!(ColorChoice); /// ``` #[macro_export] macro_rules! value_parser { From c92e4b5f0131634c79f3746041faddca616be471 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 24 Apr 2023 22:16:10 -0500 Subject: [PATCH 2/3] style: Resolve warning --- clap_derive/src/parse.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clap_derive/src/parse.rs b/clap_derive/src/parse.rs index 7d7e19cdc77..b26104e119f 100644 --- a/clap_derive/src/parse.rs +++ b/clap_derive/src/parse.rs @@ -207,8 +207,8 @@ impl Parse for ClapAttr { } "default_value_t" => Ok(DefaultValueT(name, None)), "default_value_os_t" => Ok(DefaultValueOsT(name, None)), - "about" => (Ok(About(name))), - "author" => (Ok(Author(name))), + "about" => Ok(About(name)), + "author" => Ok(Author(name)), "version" => Ok(Version(name)), "skip" => Ok(Skip(name, None)), From f95385bf36ecb935de8f988e0a75e9ccfed27291 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Mon, 24 Apr 2023 22:17:04 -0500 Subject: [PATCH 3/3] doc: Escape literals --- src/builder/arg.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/builder/arg.rs b/src/builder/arg.rs index fb42d87e2dc..7ff6136a6be 100644 --- a/src/builder/arg.rs +++ b/src/builder/arg.rs @@ -5324,7 +5324,7 @@ impl Default for ArgProvider { } } -/// Write the values such as +/// Write the values such as ` ` pub(crate) fn display_arg_val(arg: &Arg, mut write: F) -> Result<(), E> where F: FnMut(&str, bool) -> Result,