From d934f27bf7a3ee0efd1a4a87b8a75ec274ea54ff Mon Sep 17 00:00:00 2001 From: Jack Date: Mon, 10 Feb 2025 19:45:39 +0000 Subject: [PATCH 1/2] Fix `boost` installation script The [coverage action is failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/13248710933/job/36981292995) because the `boost` installation mirror [is dead](https://landing.jfrog.com/reactivate-server/boostorg). Changes: - update installation link to use `boost` archive - refactored script - use long-form command names - fix shellcheck warnings - avoid writing temporary download files to disk --- .github/workflows/coverage-report.yaml | 2 ++ scripts/install-boost.sh | 11 +++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coverage-report.yaml b/.github/workflows/coverage-report.yaml index cf49c3080b..bc52e4146f 100644 --- a/.github/workflows/coverage-report.yaml +++ b/.github/workflows/coverage-report.yaml @@ -1,6 +1,8 @@ name: Code coverage report to Codecov on: + # TODO REMOVE + pull_request: push: branches: - master diff --git a/scripts/install-boost.sh b/scripts/install-boost.sh index 6db8b06c3b..a41c7def87 100755 --- a/scripts/install-boost.sh +++ b/scripts/install-boost.sh @@ -3,18 +3,17 @@ # Installs Boost from source # usage: ./install-boost.sh -set -e +set -o errexit ${RUNNER_DEBUG:+-x} -if [ "$#" -ne 1 ]; then +if [[ "$#" -ne 1 ]]; then echo "usage: $0 " exit 1 fi TARBALL_NAME=boost_$(echo "$1" | tr . _) -curl --silent -Lo $TARBALL_NAME.tar.gz https://boostorg.jfrog.io/artifactory/main/release/$1/source/$TARBALL_NAME.tar.gz -tar xzf $TARBALL_NAME.tar.gz -cd $TARBALL_NAME +curl --silent --location "https://archives.boost.io/release/${1}/source/${TARBALL_NAME}.tar.gz" | tar xzf - +pushd "${TARBALL_NAME}" ./bootstrap.sh ./b2 --with-thread --with-chrono install -cd .. +popd From 42e74d788f2cb1a357d726525e15e8fb8247c2f7 Mon Sep 17 00:00:00 2001 From: Jack Green Date: Mon, 10 Feb 2025 19:48:47 +0000 Subject: [PATCH 2/2] Update coverage-report.yaml --- .github/workflows/coverage-report.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/coverage-report.yaml b/.github/workflows/coverage-report.yaml index bc52e4146f..cf49c3080b 100644 --- a/.github/workflows/coverage-report.yaml +++ b/.github/workflows/coverage-report.yaml @@ -1,8 +1,6 @@ name: Code coverage report to Codecov on: - # TODO REMOVE - pull_request: push: branches: - master