Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support notification #43

Open
duynguyenhoang opened this issue Aug 9, 2018 · 6 comments
Open

Support notification #43

duynguyenhoang opened this issue Aug 9, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@duynguyenhoang
Copy link
Collaborator

Hi @haskellcamargo, it would be nice to have the notification.

I am working on it to support notification, the first version will be supported for MacOS only.

@haskellcamargo
Copy link
Owner

Cool! For Linux, after your PR, we can be working with an integration with libnotify (for Windows I still have no idea, by the way). Thank you for your effort!

@haskellcamargo haskellcamargo added the enhancement New feature or request label Aug 9, 2018
@infinite-Joy9l
Copy link

@duynguyenhoang whats the update on this? In case you need help please let me know.

@duynguyenhoang
Copy link
Collaborator Author

duynguyenhoang commented Aug 14, 2018

Hi @infinite-Joy9l
It would be nice if you can use below branch to check notification feature

https://github.com/duynguyenhoang/sclack/tree/feature/add_notification

This branch supported both MacOS and Linux (tested with Fedora)

@haskellcamargo
Copy link
Owner

@duynguyenhoang I've just invited you to have write access to this repository. I'm very grateful for the work you are doing on this. Thank you!

@infinite-Joy9l
Copy link

@duynguyenhoang do you know a good way to test this. I am facing issues where the conversations are not updating as well and hence not sure if the notifications are working or not.

@duynguyenhoang
Copy link
Collaborator Author

@infinite-Joy9l I am able to receive new messages, Could you please try it again?

Seem the problem with receiving new messages only occur in some cases. I am going to check it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants