Skip to content

Possible security issue with user name-contact page #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AliasQli opened this issue Jul 21, 2022 · 4 comments · Fixed by #1111
Closed

Possible security issue with user name-contact page #1106

AliasQli opened this issue Jul 21, 2022 · 4 comments · Fixed by #1111
Labels

Comments

@AliasQli
Copy link
Contributor

Page https://hackage.haskell.org/user/:username/name-contact can be visited without authorization where :username can be any username, and user's full name and email can be viewed on that page. This seems to be a security issue.

@AliasQli
Copy link
Contributor Author

Quick fix: add guardAuthorised_ [IsUserId uid, InGroup adminGroup] to Distribution.Server.Features.UserDetails.handlerGetUserNameContactHtml.

@gbaz
Copy link
Contributor

gbaz commented Jul 21, 2022

I don't think that we ever considered names and emails to require security -- the users are primarily package uploaders, and their contact information is expected to be public.

@phadej
Copy link
Contributor

phadej commented Jul 21, 2022

@gbaz that's plain wrong

On https://hackage.haskell.org/users/register-request it's very clearly stated that

Your email address will be used to confirm your account (and if you ever need to reset your password). It will also be used if one of the site administrators ever needs to contact you. It will not be displayed on the website (but note that email addresses in .cabal files that you upload are public).


the users are primarily package uploaders, and their contact information is expected to be public.

My account management email may well be different from "send all spam here" email. (or I might use [email protected] to help me organize email - small thing, but it's fun to see from which package pages bots found my email! ;) )

@phadej phadej added the bug label Jul 21, 2022
@gbaz
Copy link
Contributor

gbaz commented Jul 21, 2022

Oh fair 'nuff. In that case a pr changing this is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants