Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of hGetContents and hGetContentsN. #9

Closed
danidiaz opened this issue Apr 10, 2018 · 1 comment · Fixed by #21
Closed

Update documentation of hGetContents and hGetContentsN. #9

danidiaz opened this issue Apr 10, 2018 · 1 comment · Fixed by #21

Comments

@danidiaz
Copy link

danidiaz commented Apr 10, 2018

The documentation states the following about hGetContents and hGetContentsN:

The handle is closed on EOF.

Looking at the code, that doesn't seem to be the case. And that is good! It makes more sense this way and fits better with how pipes-bytestring works. So perhaps the documentation should be updated, removing the references to handles being closed on EOF.

@fosskers fosskers linked a pull request Sep 12, 2020 that will close this issue
@fosskers
Copy link
Collaborator

Fixed. Sorry this took so long to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants