Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suffix optional to SA #41

Open
lokeshjawane opened this issue Jun 9, 2019 · 4 comments
Open

Make suffix optional to SA #41

lokeshjawane opened this issue Jun 9, 2019 · 4 comments

Comments

@lokeshjawane
Copy link

We are creating the GCP service account & SA keys dynamically. But some we are looking for an option, where we can make prefix(vault) & suffix(intSuffix) optional while creating SA, which currently doesn't exist.

Would be great if we can have one boolean to enable and disable SA prefix & suffix.

@emilymye
Copy link
Contributor

I'm hesitant to remove all randomness (int suffix) since an GCP IAM policy doesn't actually check that the accounts under its bindings exists, so you could run into unexpected permissions result from name collision if Vault fails before revoking old permissions. It's not foolproof but it is a small safety measure.

Would it make sense for us to instead add a preferred "name" or "name-prefix" field that you can specify for the roleset?

@karlkfi
Copy link

karlkfi commented Aug 15, 2019

We have a similar problem:

When you change a roleset it generates a new service account, which makes it a PITA to apply any role bindings to the service account outside of Vault.

Option A:
Make it possible for users to create the service account outside of Vault and specify that specific pre-existing service account to use for a roleset.

Option B:
Dont change the service account after creation.

Option C:
Remove the random suffix so the account name doesn’t change.

@dustin-decker
Copy link

I think having both option A (bring your own SA) and option C (remove suffix) as an optional boolean in the roleset (default false) would be ideal.

@julianvmodesto
Copy link

@emilymye do you have a preference for one or more implementation options above? If you'd accept both option A and option C, then would you prefer that option A (preferred name prefix) is implemented first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants