Skip to content

Commit ee57b2d

Browse files
committed
[ingress] default api-version to v1 and allow set
1 parent a685664 commit ee57b2d

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

templates/server-ingress.yaml

+5-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
{{- $serviceName = printf "%s-%s" $serviceName "active" -}}
88
{{- end }}
99
{{- $servicePort := .Values.server.service.port -}}
10-
{{ if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }}
10+
{{ if .Values.server.ingress.apiVersion }}
11+
apiVersion: {{ .Values.server.ingress.apiVersion }}
12+
{{ else if .Capabilities.APIVersions.Has "networking.k8s.io/v1" }}
13+
apiVersion: networking.k8s.io/v1
14+
{{ else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }}
1115
apiVersion: networking.k8s.io/v1beta1
1216
{{ else }}
1317
apiVersion: extensions/v1beta1

test/unit/server-ingress.bats

+23
Original file line numberDiff line numberDiff line change
@@ -120,4 +120,27 @@ load _helpers
120120
. | tee /dev/stderr |
121121
yq -r '.spec.rules[0].http.paths[0].backend.serviceName' | tee /dev/stderr)
122122
[ "${actual}" = "RELEASE-NAME-vault" ]
123+
}
124+
125+
@test "server/ingress: api version capabilities default" {
126+
cd `chart_dir`
127+
128+
local actual=$(helm template \
129+
--show-only templates/server-ingress.yaml \
130+
--set 'server.ingress.enabled=true' \
131+
. | tee /dev/stderr |
132+
yq -r '.apiVersion' | tee /dev/stderr)
133+
[ "${actual}" = "networking.k8s.io/v1" ]
134+
}
135+
136+
@test "server/ingress: api version custom" {
137+
cd `chart_dir`
138+
139+
local actual=$(helm template \
140+
--show-only templates/server-ingress.yaml \
141+
--set 'server.ingress.enabled=true' \
142+
--set 'server.ingress.apiVersion=networking.k8s.io/v2' \
143+
. | tee /dev/stderr |
144+
yq -r '.apiVersion' | tee /dev/stderr)
145+
[ "${actual}" = "networking.k8s.io/v2" ]
123146
}

0 commit comments

Comments
 (0)