command/meta: validate config right away #8591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,6 @@ variable "baz" { | |||
|
|
|||
| default = { | |||
| "A" = "a" | |||
| interp = "${file("t.txt")}" | |||
There was a problem hiding this comment.
@jen20 I noticed this was here. We've always had validation that this shouldn't work (interpolations not allowed as variable defaults). This was passing when it shouldn't have. Is this okay to remove? It doesn't work anyways.
There was a problem hiding this comment.
Yes, this should be fine to remove.
|
This LGTM - merged locally and verified the test runs etc. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8524
We were running
Inputbefore ever validating the configuration. This makes sense becauseContext.Validaterequire vars be set before running. However, we should always validate the configuration itself before doing anything else to catch issues like the above that is fixed.This caught some errors in the tests I had to fix which should've never worked, you can't have interpolated defaults in variables for example.