provider/aws: Update VPC Peering connect accept/request attributes (supersedes #8338)

[catsby]

This PR continues #8338 by reading the peering options regardless if present.
I'm currently seeing a diff on accepter though so this is a WIP

[kwilczynski]

@catsby this is how my original code looked like. The constant change to accepter is what prompted me to apply the approach from #8338.

[catsby]

@kwilczynski I think using TypeSet is better here, and removes this issue we were hitting:

• e87a9a9

[jen20]

We probably want to tend towards errwrap.Wrapf("Error creating VPC Peering Connection: {{err}}", err) here

[catsby]

Updated to fix a panic, changing the nested accepter and requester attributes to have defaults matching the API instead of being optional, computed

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRouteTable_vpcPeering -timeout 120m
=== RUN   TestAccAWSRouteTable_vpcPeering
--- PASS: TestAccAWSRouteTable_vpcPeering (31.36s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    31.387s

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVPCPeeringConnection -timeout 120m
=== RUN   TestAccAWSVPCPeeringConnection_importBasic
--- PASS: TestAccAWSVPCPeeringConnection_importBasic (18.29s)
=== RUN   TestAccAWSVPCPeeringConnection_basic
--- PASS: TestAccAWSVPCPeeringConnection_basic (18.37s)
=== RUN   TestAccAWSVPCPeeringConnection_plan
--- PASS: TestAccAWSVPCPeeringConnection_plan (19.48s)
=== RUN   TestAccAWSVPCPeeringConnection_tags
--- PASS: TestAccAWSVPCPeeringConnection_tags (18.36s)
=== RUN   TestAccAWSVPCPeeringConnection_options
--- PASS: TestAccAWSVPCPeeringConnection_options (32.88s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    107.415s

[jen20]

LGTM, I think we can consider the acceptor -> accepter thing later.

[kwilczynski]

@jen20 I believe that "accepter" is not a typo.

"acceptor", a noun, meaning "one who accepts";
"accepter", a noun, meaning "a person who accepts".

1. http://www.homophone.com/h/accepter-acceptor
2. http://www.merriam-webster.com/dictionary/accepter
3. http://www.merriam-webster.com/dictionary/acceptor
4. http://docs.aws.amazon.com/AmazonVPC/latest/PeeringGuide/working-with-vpc-peering.html

The latter is more common in American English, IIRC.

Regardless of the spelling, the AWS documentation and the API spell it as "accepter", and there is a prerogative to follow the API/documentation as closely as possible, which is what I did.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.