provider/google: Support Import of 'google_compute_firewall'

[nwwebb]

make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeFirewall' 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeFirewall -timeout 120m
=== RUN   TestAccComputeFirewall_importBasic
--- PASS: TestAccComputeFirewall_importBasic (206.71s)
=== RUN   TestAccComputeFirewall_basic
--- PASS: TestAccComputeFirewall_basic (86.25s)
=== RUN   TestAccComputeFirewall_update
--- PASS: TestAccComputeFirewall_update (107.32s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google
400.331s

make testacc TEST=./builtin/providers/google TESTARGS='-run=TestComputeFirewallMigrate' 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/google -v -run=TestComputeFirewallMigrate -timeout 120m
=== RUN   TestComputeFirewallMigrateState
--- PASS: TestComputeFirewallMigrateState (0.00s)
=== RUN   TestComputeFirewallMigrateState_empty
--- PASS: TestComputeFirewallMigrateState_empty (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google
0.058s

Read was not working for the ports attribute of allow. I tried to set it in the same way as other TypeSets (target_tags for example) and it seemed to not be working because it was nested within allow. I fixed this issue by changing ports to a TypeList. I added a state migration for changing ports from a TypeSet to TypeList so that existing states are not effected by this change.
@lwander

[lwander]

Looks like a unit test is failing for the migration

[lwander]

Could you explain in the PR what motivated this change?

[nwwebb]

I edited the PR to explain the change

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.