provider/aws: Fix issue updating ElasticBeanstalk Environment Settings

[catsby]

Fixes the logic that updated settings for Elastic Beanstalk Environments.
Because the update is done in the same API call, we need to split removals /
additions.

Fixes #6890

[dharrisio]

@catsby do we need to take into account the ResourceName setting attribute here as well? I have a feeling this may not work as intended with more than one scheduled action (http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/command-options-general.html#command-options-general-autoscalingscheduledaction)

This attribute can be a bit frustrating, because it is only documented for scheduled actions, but is returned by the api for some other settings. To avoid the issues that caused I had to do this https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_elastic_beanstalk_environment.go#L717

[catsby]

In the statefile, we ignore ResourceName unless it's a scheduled action. I think here I'll check if the local setting has ResourceName and then check if they match, continuing if they do not match. If we don't have it set locally, I'll just continue on as we have here. Does that sound reasonable?

[catsby]

I added a check in 0cec643 ea8f161 that I think covers this

[dharrisio]

@catsby Sorry for the delayed response here, been out for a bit. This sounds good to me!

Thanks!

[catsby]

updated with acc test

[stack72]

LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.