provider/openstack stop before destroy

[alkersan]

@jtopjian Please review this patch for #7129 behavior. It includes 1 added dependency to gophercloud package and basic opt-in implementation of stop_before_destroy flag.

Need advice on acceptance test for it. Currently it was tested manually within corporate openstack setup.

First scenario was a mini consul cluster, where clients were configured with leave_on_terminate option. When I scaled down consul machines - they correctly left cluster and disappeared from node catatlog, thus it subjectively proves that Nova sent ACPI shutdown signal to guests OS. Without stop_before_destroy consul shows all nodes in failing state.

Another check is to peek at instance action history API. With stop_before_destroy enabled, action history should include stop:

+--------+------------------------------------------+---------+----------------------------+
| Action | Request_ID                               | Message | Start_Time                 |
+--------+------------------------------------------+---------+----------------------------+
| create | req-e0d5c543-161a-43a0-9fb5-527b802faa03 | -       | 2016-06-15T20:01:39.000000 |
| stop   | req-b86d88e3-8916-47e3-a139-8b0cf5cfb35a | -       | 2016-06-15T20:03:47.000000 |
+--------+------------------------------------------+---------+----------------------------+

But, unfortunately, I didn't find implementation of history API in gophercloud

[jtopjian]

@alkersan Nice work!

I agree -- creating an acceptance test that confirms end-to-end functionality for this is difficult. I think creating a simple test that verifies the new argument works without error is good enough. In this case, just make a copy of the "basic" acceptance test but add stop_before_destroy = true 😄

[alkersan]

@jtopjian ok, simple acc test is there and branch was rebased on fresh master

[jtopjian]

@alkersan this looks great! I just ran the acceptance test suite and everything passed.

Would you be able to squash the commits into two: one for the Gophercloud deps and the other for everything else? Once that's done, I'll go ahead and merge this in 😄

[alkersan]

@jtopjian done

[jtopjian]

@alkersan Thank you, sir!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.