google_compute_vpn_gateway does not work if region not specified

[clstokes]

When trying to create a google_compute_vpn_gateway resource, if the region is not specified, Terraform will create the VPN gateway, but is then unable to read it (a 404 is returned) and no error is reported. At this point, the gateway has been created, but the gateway's details are not persisted in Terraform's state. Subsequent applies and destroys will fail.

If I specify the region (commented below), Terraform works fine. It seems that resourceComputeVpnGatewayRead() should be reading the region from getOptionalRegion() as other Google resources do. In fact, changing this locally fixes this, but I'm unsure if there are other implications of this change.

google_compute_vpn_gateway

resource "google_compute_network" "main" {
  name = "tf-test"
  ipv4_range = "172.17.0.0/16"
}

resource "google_compute_address" "vpn" {
  name = "tf-test"
}

resource "google_compute_vpn_gateway" "vpn" {
  name = "tf-test"
  network = "${google_compute_network.main.self_link}"
  #region = "us-central1"
}

google_compute_vpn_tunnel

This occurs for google_compute_vpn_tunnel too. Full config to reproduce is at https://gist.github.com/clstokes/7b89b5542c02deedddc6.

Docs issue (?)

The compute_vpn_gateway docs say If not specified, the project region will be used. where other resources say If it is not provided, the provider region is used. I'm not sure if this is a typo or there actually is a distinction between project and provider region.

[clstokes]

Edited to include details about google_compute_vpn_tunnel too.

[lwander]

Good catch! Submitted a fix #5125

[jen20]

Fixed by #5125 - nice catch @clstokes!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.