-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Autoscaling Group Scheduled Actions #4256
Conversation
9040111
to
90fd72b
Compare
Computed: true, | ||
ValidateFunc: validateASGScheduleTimestamp, | ||
}, | ||
"end_time": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make use of the (new) resource-level ValidateFunc to ensure that end_time
> start_time
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this hasn't yet been merged, sorry!
LGTM! I've put a couple of minor comments inline - not sure if the API validates that |
90fd72b
to
c965d22
Compare
provider/aws: Autoscaling Group Scheduled Actions
@jen20 do you know if you can define a single schedule resource but assign multiple ASGs (pretty much takes an array for |
@scalp42 right now, the api only allows a single autoscaling_group_name: http://docs.aws.amazon.com/cli/latest/reference/autoscaling/put-scheduled-update-group-action.html |
👍 |
@scalp42 FWIW its a great suggestion :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
As requested in #2367 & #4211
Test Results: