Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC service control supported on VPC peering connections? #9317

Closed
Celestica-Edward opened this issue Jun 7, 2021 · 9 comments
Closed

VPC service control supported on VPC peering connections? #9317

Celestica-Edward opened this issue Jun 7, 2021 · 9 comments

Comments

@Celestica-Edward
Copy link

Celestica-Edward commented Jun 7, 2021

Affected Resource(s)

  • google_service_networking_*

Hi,

We would like to manage this in terraform:
https://cloud.google.com/sdk/gcloud/reference/services/vpc-peerings/enable-vpc-service-controls
https://cloud.google.com/sdk/gcloud/reference/services/vpc-peerings/disable-vpc-service-controls

Example:
gcloud services vpc-peerings enable-vpc-service-controls
--network=xxxxx
--service=servicenetworking.googleapis.com

This is used at least in peering connections to GCP VMware engine:
https://cloud.google.com/vmware-engine/docs/networking/howto-setup-internet-access#enable_internet_access_by_using_an_on-premises_connection

References

  • b/312371408
@megan07 megan07 added the size/s label Jun 14, 2021
@megan07 megan07 added this to the Goals milestone Jun 14, 2021
@mmalet-sky
Copy link

We are also needing this feature, I expect it'll need to be added as an vpc_service_controls_enabled = {true|false} option on the service_networking_connection

@roaks3
Copy link
Collaborator

roaks3 commented Oct 6, 2022

b/251560503

@roaks3
Copy link
Collaborator

roaks3 commented Nov 15, 2022

This issue is blocked as we work with the service team to provide a way to read this value.

@rileykarson
Copy link
Collaborator

rileykarson commented Nov 21, 2023

Not having that isn't great, but is only really a blocker for import. We can manage the enablement status in Terraform state- it just might drift.

@juliocc
Copy link

juliocc commented Dec 5, 2023

The API for this just became available (see b/263492666).

I have a customer waiting for this to become available in terraform. If no one is working on this, I have some bandwidth to give it a try.

Let me know if thats OK.

@rileykarson
Copy link
Collaborator

I'd suggest flagging you're looking at it on the service's Terraform-specific issue (b/312371408, linked from the GH issue parent) but other than any concerns raised there (I don't expect any) should be fine to do so.

@tim-harpe
Copy link

+1

@c2thorn
Copy link
Collaborator

c2thorn commented Jul 9, 2024

closed by GoogleCloudPlatform/magic-modules#10899

@c2thorn c2thorn closed this as completed Jul 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants