google_cloud_run_service doesn't show details when definition is invalid

[charleskorn]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.18
+ provider.google v3.15.0

Affected Resource(s)

• google_cloud_run_service

Terraform Configuration Files

resource "google_cloud_run_service" "service" {
  name     = "myservice"
  location = "us-central1"

  template {
    spec {
      containers {
        image = var.image_reference
      }
    }

    metadata {
      name = "abc123"
    }
  }
}

Debug Output

Relevant log lines: https://gist.github.com/charleskorn/28b6424b4251a720a938611221d26ee0

Expected Behavior

terraform apply includes details of why the definition is invalid as returned by the API, for example:

Error: Error updating Service "locations/us-central1/namespaces/myproject/services/myservice": googleapi: Error 400: The request has errors: The revision name must be prefixed by the name of the enclosing Service or Configuration with a trailing -

  on service.tf line 28, in resource "google_cloud_run_service" "service":
  28: resource "google_cloud_run_service" "service" {

Actual Behavior

terraform apply displays a generic "the request has errors" message with no details on what is invalid, even though the Cloud Run API response (in debug logs) includes a detailed error message

Error: Error updating Service "locations/us-central1/namespaces/myproject/services/myservice": googleapi: Error 400: The request has errors

  on service.tf line 28, in resource "google_cloud_run_service" "service":
  28: resource "google_cloud_run_service" "service" {

[venkykuberan]

@charleskorn I have noticed cloudrun API isn't sending detail description of the error in the message attribute for other failures too. We will append the fieldViolations description in the provider returned error message.

[rileykarson]

Filed a bug against the team upstream to return the useful error message in the message that we parse. We don't have a precendent for parsing details in the provider- they're generally (externally) undocumented formats that we're hesitant to hook in to.

b/153896811 for my / other team members' reference.

[rileykarson]

Deduping to #6263, which would solve this generally.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!