Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeLocalDNS as beta for "google_container_cluster" #5150

Closed
inductor opened this issue Dec 12, 2019 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#3126, #5887 or hashicorp/terraform-provider-google-beta#1853

Comments

@inductor
Copy link

inductor commented Dec 12, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add NodeLocalDNS feature as it has been promoted to beta

New or Affected Resource(s)

  • google_container_cluster

Potential Terraform Configuration

addons_config {
  node_local_dns {
    disabled = true
  }
}

References

https://cloud.google.com/sdk/gcloud/reference/beta/container/clusters/create

@ghost ghost added the enhancement label Dec 12, 2019
@inductor inductor changed the title Add NodeLocalDNS as beta for "container_cluster" Add NodeLocalDNS as beta for "google_container_cluster" Dec 12, 2019
@danawillow danawillow added this to the Goals milestone Dec 16, 2019
@danawillow
Copy link
Contributor

Internal at b/141945015.

Also note to the implementer to make sure we warn in the docs about recreating nodes.

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.