Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver Service Monitoring #5058

Closed
danawillow opened this issue Dec 3, 2019 · 7 comments
Closed

Stackdriver Service Monitoring #5058

danawillow opened this issue Dec 3, 2019 · 7 comments

Comments

@danawillow
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services
https://cloud.google.com/monitoring/api/ref_v3/rest/v3/services.serviceLevelObjectives

New or Affected Resource(s)

  • google_monitoring_service
  • google_monitoring_slo (or service_level_objective)

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

b/142965924

@danawillow
Copy link
Contributor Author

google_monitoring_custom_service and google_monitoring_app_engine_service added in GoogleCloudPlatform/magic-modules#3341
google_monitoring_slo added in GoogleCloudPlatform/magic-modules#3363

All 3 will be in v3.18.0, releasing later today.

Keeping this issue open for now as per comment in GoogleCloudPlatform/magic-modules#3341:

Add other datasources google_monitoring_cloud_endpoints_service, google_monitoring_mesh_istio_service, etc: This needs extra resources outside of GCP/monitoring to test, so I'm excluding them until I figure out how to get testing resources for them.

@danawillow danawillow modified the milestones: Sprint 10, Sprint 11 Apr 21, 2020
@matthias-froomle
Copy link

Is there any timeline on the support of requestBased and windowsBased SLO's for custom services in the google_monitoring_slo resource?

@danawillow
Copy link
Contributor Author

It's being actively worked on now, so I'd expect within the next few weeks (this issue is part of our upcoming sprint- you can see that in the Milestone field)

@emilymye emilymye modified the milestones: Sprint 11, Sprint 12 May 11, 2020
@tmarszal
Copy link

@emilymye, thanks a lot for implementing it. I am going to clone master and try to use it on my dev environment right away

@emilymye
Copy link
Contributor

Request and Window based SLOs are now supported in #3491 and #3510

@emilymye
Copy link
Contributor

@danawillow I'm going to add additional datasources for cloud endpoints and cluster/mesh istio but track in a different issue

@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 20, 2020
@github-actions github-actions bot added service/monitoring-services forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants