Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping from "google_project_services" to "google_project_service" causes API rate limiting error #4689

Closed
yinzara opened this issue Oct 16, 2019 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#2480
Assignees
Labels

Comments

@yinzara
Copy link

yinzara commented Oct 16, 2019

When a project has numerous services enabled, using the "google_project_service" resource causes multiple API requests during a refresh which can often go over the API limits. By using the "google_project_services" resource, this is limited to a single API call. I was only able to fix issues with my project by swapping to using the now deprecated "google_project_services". I believe this deprecation needs to be revisited.

@rileykarson
Copy link
Collaborator

rileykarson commented Oct 16, 2019

Are you using a recent version of the provider? 2.13.0 and onwards support Batching which should cause multiple google_project_service resources to send a single request. It should be on by default.

Debug logs would be a big help, if batching isn't working for some reason. If those don't work, if you've got a list of services that will hit rate limits that would also be a big help.

@yinzara
Copy link
Author

yinzara commented Oct 16, 2019

That does seem to have fixed my issue. I appreciate it. Didn't realize that was added.

@yinzara yinzara closed this as completed Oct 16, 2019
@rileykarson
Copy link
Collaborator

Great! I'm going to use this issue to track updating some of the deprecation warnings to note that users should upgrade to 2.13.0+.

@ghost
Copy link

ghost commented Nov 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants